I started writing this quite a while ago, the "last modified date" before this evening was (iirc) just before I started writing SABRE Maps!

Anyway, editing wiki gallery pages has suddenly got a little bit easier. If you now click on "Edit" on a picture (such as one submitted to POTM), instead of an impenetrable page of text, you get more or less the same user interface as the upload page.

There are two main flaws as present. One, the full UI to select galleries is not there yet. Two - saving an image is two steps. You have to click "Confirm", to confirm your changes, which changes the actual edit window beneath. Then you can click on "Save". Both of these issues will be fixed in due course!

In the mean time - have a play and see what you think.

Now I'm happy the editor is working, I have got rid of the cumbersome and irritating two step process.

When you now edit a gallery image, you get a straightforward "Save" button. Click on that, and the changes to the image are saved, exactly as you'd expect.

There is a "Cancel" button to abandon changes, but it's hidden - I'll fix this probably when I get round to putting in selectable galleries.

Looks good. I tried to add co-ordinates to one image though (here), making no other changes, and the change disappeared into the ether.

EDIT: Tried it again this time and it worked. Odd.

That'll be that session data bug. I'll have a serious look into that one of these evenings.

Now that this feature is up and running, I've started to look at the Category:Pictures without coords category, which shows every image that hasn't got a location added to it. There's lots of them!

Any chance we can have the map as a Google map, as in the upload form? It's difficult to correctly position an image without the satellite option!

Sure, as long as you can find a developer who knows how to use the Google Maps control API.

Actually, I quite like the OpenStreetMap interface - so ideally I will change everything to allow a choice of either.

Not as simple as re-using the code from the upload form?

Spotted a slight bug, see this diff...

http://www.sabre-roads.org.uk/wiki/inde ... did=158953

The code you're using to extract the information from the template seems to take "|photographer = [[User:Aandy|Aandy]]" and turn it into "|photographer = [[User:Aandy".

<Trying to be useful>Could it be that you haven't accounted for legitimate pipe's within the information template?

Yes, that's a bug, for exactly the reasons you describe. What regular expression would trap that correctly?

If I'm honest, I'm not 100% sure... regex has never been my strong point.

It's more complicated than it seems too, obviously links can be piped, but it's also possible for templates to be nested within templates, as well as the wiki syntax for a table, which could in theory be included.

Here are a couple of formats that the template could appear in, which are both valid wiki markup. The first one is more likely than the second, however.

I'll have a good look tonight and see what I can do. Thanks for the help in testing!

Just to clarify, it doesn't appear that a table would actually be valid within a template, so at least that's one less thing to worry about.

I think the way I'd consider doing it is as thus:

Isolate the links, [[Link]] or [[Piped|Link]], temporarily replace the pipe in those instances with something else.

Then isolate the templates, {{Template}} or {{Template|With|parameters=StupidAnnoyingWikiMarkup}}, again replacing the pipe with something else.

You won't find any templates within links, but you may find links within templates, so it's fairly important to do it in that order, and also bear in mind that the templates may themselves appear on multiple lines.

Then run whatever regex you're currently running, I suspect it would then work fine. When you're redisplaying the fields in the input boxes, put the previously replaced pipes back in.

I know it's a bit of a dirty way of doing it in the grand scheme of things, but it's perhaps the simplest solution in this situation without you pulling your hair out too much!

That's a page I visit every now and then because I find "sleuthing" for the exact locations is fun (whatever turns you on, as they say!) and the search often throws up many other serendipitous discoveries.

I think I've fixed the issue Jeni reported - can you try it with one that would have broken before?

Can't find where you mentioned it before, Ritchie, but thanks for the new {{Picture gallery}} editor, it makes things a lot easier, especially when you can't remember if it's Picture gallery, Picture Gallery, or what!

I hadn't got round to documenting it yet, because I wanted to test it a bit more, but it looks like you've done that for me, so cheers.

Not a problem Just one thing, though, where does/will the description text appear as it seems to disappear into the ether at the moment.

Coppermine had descriptions, so I decided it would be good to have them here too. Just haven't made a decision yet where to put them. Probably at the top of the gallery and in small for the list in its parent.

Its major flaw at the moment is that it doesn't create the hidden category you need for stuff to work.