User talk:Ritchie333/2009

Removal of the Unique Key

What's up with removing the Unique Key thing you installed? It seemed a good idea... M5lenzar 13:23, 21 May 2009 (UTC)

The last fix I did screwed some things up, and when I rolled back it seemed to jump back multiple versions rather than the last one. Should be okay now, but categories still wrong for multiple routeboxes for the time being. --Ritchie333 13:27, 21 May 2009 (UTC)

Its worth noting that every edit to the routebox adds over 10,000 jobs to the job queue, which currently stands at almost 30,000 (Special:Statistics). Yes the queue now gets emptied overnight, but it causes havoc when trying to update other templates between now and then. Can we try to keep edits to the Routebox template to a minimum? jeni 13:52, 21 May 2009 (UTC)

Okay. Might be nice to see if there's a backdoor to allow developers to manually flush the queue. --Ritchie333 13:56, 21 May 2009 (UTC)

Train Services

Hi Ritchie.I thought that the through service from Ashford to Brussels had been cancelled? Local info please. Bob 10:28, 24 Oct 2009

Hi Bob. Services to Brussels reopened in February 2009, and in May 2009 I used this service for a weekend away in Belgium.--Ritchie333 10:59, 24 October 2009 (UTC)

Humber Bridge

Hi Ritchie. I was not happy with the positioning on my Humber Bridge entry and see that you have re-formatted it.Good. However the new formatting shows an overlap and is worse than the orginal. Can you have another go please. NB. I have just noticed a spelling mistake on the original 'Bridges' input(Lincolnshire). Bob 15:00, 24 November 2009 (UTC)

Hi Bob. Looks like Jeni got there first! --Ritchie333 16:50, 24 November 2009 (UTC)

Bot problem

While I've been away for the evening, a problem appears to have occurred with JeniBot, it is now throwing up errors every time it attempts to edit a page.. "HTTP Referrer not valid". I know you have been playing with the code behind the scenes, is there anything you may have done that could have caused this? It still edits, if I manually click through around 10 warnings on each edit, which rules out any automatic running (and any reasonable manual running). Is there any chance you could remove any modified code temporarily at some point tomorrow, so I can test and possibly rule out any problems with your code? (I'd do it myself, but I don't know where you have edited!). Thanks! Jeni ^(talk) 01:52, 28 November 2009 (UTC)

Hi. I haven't a clue about Referers (mainly because you can fake just about anything on them to make them not worth normally bothering with), but one possibility is the inclusion of a local JavaScript file instead of giving it a full URL. I've now done this. If you're still getting problems, you can stub out the OpenSpace extension by commenting out line 208 of LocalSettings.php, which calls in the extension. Can you tell me a bit more about your bot software, as I have absolutely no idea how it works. --Ritchie333 11:05, 28 November 2009 (UTC)

I'm getting that too, though simply when I click on things in Firefox - I'm not trying to do anything clever at all. steven 12:01, 28 November 2009 (UTC)

JeniBot uses AWB (all the information about it you may need is there), though if Steven is getting similar problems just using Firefox, it may be a deeper problem, that said, it is working fine for me in Firefox 3.5.5. I'll temporarily remove your code just to see if its that which is causing the problem. Jeni ^(talk) 14:32, 28 November 2009 (UTC)

Right, I've disabled the openspace extension, and everything works fine now, so there is something in the extension which is causing AWB to throw the "HTTP Referrer not valid error". I'll be completely honest and say that I have absolutely no idea what it could be. Did the errors Steven received give any more information? Jeni ^(talk) 14:43, 28 November 2009 (UTC)

I doubt it - I got exactly the same error message as you with AWB. I was using FF 3.5.5. as well. steven 15:14, 28 November 2009 (UTC)

Was the error on every page? Did it only happen once per page? In AWB it was throwing up a good number (of the same warning) on each page load. Jeni ^(talk) 15:22, 28 November 2009 (UTC)

Hi guys. I can repro this on Firefox 3.5.5 by browing to http://sabre-roads.org.uk/demo/tomos.html (which is more or less the code that the OpenSpace extension generates). I get an alert box appearing stating : "A problem has occurred: HTTP Referrer not valid". On further investigation, it seems that the call to get the relevant JavaScript from the Ordnance Survey website is returning this instead of the "real" code. I'd need to get access to the OpenSpace support forums, and only Tom has the login details. --Ritchie333 10:15, 29 November 2009 (UTC)

Scratch that, I've fixed it! When you browse to the wiki (well, at least with the OpenSpace extension turned on) - you must use the address www.sabre-roads.org.uk. If you use anything else, including sabre-roads.org.uk - you will get the "HTTP Referrer not valid" error, and you will then always get that error until you clear your browser's cache from before the moment you clicked on the wrong URL. (ctrl+shift_delete works in Firefox 3.5.5).

The fix, therefore, is to automatically redirect sabre-roads.org.uk to www.sabre-roads.org.uk, probably via an .htaccess file. --Ritchie333 10:21, 29 November 2009 (UTC)

Thanks Ritchie. For some reason when we first started using AWB, it wouldn't accept www.sabre-roads.org.uk, yet now it does :) works all round! One last thing before we go live, can you alter the openspace code so that it accepts lon rather than long as a parameter, so its compatible with the googlemaps extension just by altering the tag name. When you have done that, it'll just be a case of adding |maptype = openspace to Template:Primary Destination to enable it. Jeni ^(talk) 12:32, 29 November 2009 (UTC)

Done, and done! Job queue flushing as I write this! --Ritchie333 12:43, 29 November 2009 (UTC)

:) Just had a look at a random selection of PD's, I think we may benefit from editing the zoom code to zoom out one more. You said you were originally going to half the google zoom to get the OS zoom, perhaps oszoom = (googlezoom / 2) - 1 would work a little bit better? Jeni ^(talk) 12:51, 29 November 2009 (UTC)

There ya go. Now, I won't be at my development PC for most of next week, so if you want any other coding changes, shout ASAP! --Ritchie333 14:13, 29 November 2009 (UTC)

Thats great, thanks. Can you do a mass find and replace and replace Staffordshire with West Midlands? ;-) Ok, I'll run away now! Jeni ^(talk) 14:19, 29 November 2009 (UTC)

I have two words for you, the second one being "off". --Ritchie333 14:20, 29 November 2009 (UTC)

And the first being "No, I don't think so"?  ;-) steven 18:54, 29 November 2009 (UTC)

Navboxes

It's actually unclosed tables which are causing the problem on certain pages. If the route list does not end with a |} then it presumes all content following it is part of the table, and thus messes everything up! A missing |} is the most common problem on pages with a route list (or any templated table for that matter. Jeni ^(talk) 15:46, 7 December 2009 (UTC)

Ah, okay. I marked which one's I'd fiddled with (I think it was only Llangurig and Stourbridge) so they should be easy to fix. --Ritchie333 15:48, 7 December 2009 (UTC)

Already fixed! Pah! Cleaning up after the president, is this what my life has come to? ;-)

On a completely unrelated note, but while I've got your attention... I'm not sure the crossing infoboxes suit the openspace map. I'd suggest road features stick to the googlemap (services, bridges, crossings, tunnels, schemes etc), while places (primary destinations, counties, authorities (if we create an infobox for them) and other towns (if we ever create any)) are better suited to the openspace map. Thoughts? Jeni ^(talk) 15:52, 7 December 2009 (UTC)

The long term aim is to make the maptype the default map selection and have a couple of other links that switch between Google Maps, OpenSpace and whatever else. This will require a new MediaWiki extension, which I'm pretty sure is technically possible (multiple divs are created and the links turn the visibility of the divs on and off). For now, my main concern has just been that the OpenSpace stuff works more reliably more than anything else. --Ritchie333 15:55, 7 December 2009 (UTC)

Have there been issues with the googlemaps extension that I've missed? I just think that in the context of the crossing pages, the aerial photos are a big thing to lose, even if its only in the short term. Jeni ^(talk) 16:06, 7 December 2009 (UTC)

I don't think there are any real problems with the Google Maps extension as designed, but personally I've never really liked Google's "map" functionality, which sucks compared to OS maps. However, Google Maps is invaluable to have because of its aerial coverage. So what I'd like is to be able to switch between "what does the Forth Road Bridge look like from above" (Google) and "what roads are near the Forth Road Bridge and where can I go" (OpenSpace). --Ritchie333 16:10, 7 December 2009 (UTC)

← I know what you mean about the style of the mapping. Personally I'd prefer it if OSM was more complete in the areas we needed it, as when its good, its good. Looking at several crossing pages, the openspace maps just don't look "right", particularly on some of the shorter bridges. Do you have any objections to me putting it back to google until we have this switch thingy? Jeni ^(talk) 16:21, 7 December 2009 (UTC)

Not really. JFDI. --Ritchie333 16:23, 7 December 2009 (UTC)

I'll be honest and say I'm not sure how to read that... is that you being annoyed? It's not a biggie, I won't change it if you do actually think it should stick with openspace. Jeni ^(talk) 16:28, 7 December 2009 (UTC)

No I'm not annoyed (well I am at something else but that's nothing related to you!) I mean I've got absolutely no issues with you reverting to it at all - we will have a long term fix. Flex your fingers and hit that revert button! --Ritchie333 16:34, 7 December 2009 (UTC)